This repository was archived by the owner on May 22, 2019. It is now read-only.
Communication over pipe made more robust. #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please consider getting in touch with the upstream Trac development |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, communication with git could get into an inconsistent state if there was some exception while communicating. And exceptions are: sometimes
splitfails (because the request is for missing commit, for example), or some other exception is thrown.Now, the communication is broken so that it can be restarted from a clean slate next time. As this does not happen so often, I don't think it makes a negative impact on performance. But once it does happen, is better that things work than to get an exception displayed to the user that something internally went wrong.